feat: cron jobs #1155
Merged
feat: cron jobs #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
matt2e
force-pushed
the
matt2e/cron-jobs
branch
8 times, most recently
from
f4c3171
to
0f50c28
Compare
|
Mind breaking this up into multiple PRs? Schema changes could be one, for example. |
|
Database changes could be another, and so on. |
This was referenced Apr 8, 2024
matt2e
added a commit
that referenced
this pull request
Apr 8, 2024
Built a cron implementation which will be used as part of our cron jobs feature (See: #1155) Splitting this off into this smaller PR to make things easier.
matt2e
added a commit
that referenced
this pull request
Apr 8, 2024
Previously a deepcopy involving nil pointers would end up with a pointer to a zero value. Needed as part of #1155
matt2e
force-pushed
the
matt2e/cron-jobs
branch
5 times, most recently
from
277571f
to
ac3efcf
Compare
matt2e
force-pushed
the
matt2e/cron-jobs
branch
7 times, most recently
from
b174655
to
2716ff7
Compare
matt2e
requested review from
alecthomas,
dhanji,
wesbillman and
worstell
as code owners
alecthomas
reviewed
Apr 12, 2024
| start := s.clock.Now().UTC() | ||
| pattern, err := cron.Parse(stale.Schedule) | ||
| if err != nil { | ||
| logger.Errorf(err, "Could not kill stale cron job %q because schedule could not be parsed: %q", stale.Key, stale.Schedule) |
There was a problem hiding this comment.
Same as above - all of these log messages should be associated with the cron job in the events table so that the user can filter and find issues with their cron jobs.
alecthomas
reviewed
Apr 13, 2024
matt2e
force-pushed
the
matt2e/cron-jobs
branch
from
92d1f9e
to
ec44bf4
Compare
alecthomas
approved these changes
Apr 15, 2024
matt2e
force-pushed
the
matt2e/cron-jobs
branch
from
37cedb2
to
d96d920
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separating into different PRs:
#1141